Skip to content

Conversation

@syn-zhu
Copy link
Collaborator

@syn-zhu syn-zhu commented May 22, 2025

Description

https://jira.mongodb.org/browse/COMPASS-9367

Fixes clusters showing up duplicated with terminated status

Mainly two issues:

  1. The "fallback" logic to v1 causes compass web to forever switch to using V1 after a single failure to call V2. The issue with this, is that sometimes v2 will fail transiently. I don't know what the exact reason is, but one way to reproduce this is to go to Data Explorer, then close your laptop lid, wait a few minutes, then open it again. When you get back to the DE page, you will see that the V2 endpoint call failed once, and now we keep calling V1 forever. I believe this fallback logic was only really needed during the initial rollout anyways, so I've updated the logic to just be a flag now, which decides to either use the new endpoint or not.
  2. Following the point above, the reason why we're seeing Terminated status in the UI is because the V1 logic still uses cluster name as connection ID, this wasn't updated in feat: update atlas cluster states COMPASS-8228 #6884. Hence, Compass thinks the old connection is deleted and new one, which has the cluster name as the connection ID, is a different connecton.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label May 22, 2025
@syn-zhu syn-zhu added the no release notes Fix or feature not for release notes label May 22, 2025
@syn-zhu syn-zhu merged commit d11e196 into main May 22, 2025
9 of 10 checks passed
@syn-zhu syn-zhu deleted the smnzhu/fix-terminated-cluster branch May 22, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants